Skip to content

Fix CMake OpenMP flag checks with CL #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2025
Merged

Fix CMake OpenMP flag checks with CL #2497

merged 2 commits into from
Dec 3, 2025

Conversation

@dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented Oct 10, 2025 •
edited
Loading

cl accepts -openmp-simd and produces:

cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release

This option is then passed to cl with a cmake message:

oneDPL: OpenMP SIMD is enabled by passing '-openmp-simd' to compiler

Obviously, this option is not supported there and confused with -o.

@dmitriy-sobolev dmitriy-sobolev changed the title Fix CMake OpenMP flag checks Fix CMake OpenMP flag checks with CL Oct 10, 2025
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/fix-cmake-omp-check branch from 1d19d05 to 6251f1d Compare December 2, 2025 16:02
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/fix-cmake-omp-check branch from 6251f1d to 18784bb Compare December 2, 2025 17:02
@dmitriy-sobolev dmitriy-sobolev marked this pull request as ready for review December 2, 2025 17:32
SergeyKopienko
SergeyKopienko approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyKopienko
Copy link
Contributor

SergeyKopienko commented Dec 2, 2025

[Non-blocking suggestion] It may be helpful in the future to emit an explicit CMake status message indicating that SIMD probing is intentionally disabled for MSVC.

@dmitriy-sobolev
Copy link
Contributor Author

dmitriy-sobolev commented Dec 2, 2025 •
edited
Loading

[Non-blocking suggestion] It may be helpful in the future to emit an explicit CMake status message indicating that SIMD probing is intentionally disabled for MSVC.

It's enough to print this message because there is no need to check any flags:

oneDPL: no effect from enabled ONEDPL_ENABLE_SIMD; unsupported for current compiler

That's because oneDPL expects OpenMP 4.0 for SIMD execution, but MSVC fully supports only OpenMP 2.0.

@dmitriy-sobolev
Copy link
Contributor Author

dmitriy-sobolev commented Dec 2, 2025 •
edited
Loading

@timmiesmith, I'd like to merge this PR for 2022.11: it is a low risk bug fix. Any objections?

@timmiesmith
Copy link
Contributor

timmiesmith commented Dec 2, 2025

@timmiesmith, I'd like to merge this PR for 2022.11: it is a low risk bug fix. Any objections?

No objection to merging this.

@dmitriy-sobolev dmitriy-sobolev merged commit af30f10 into main Dec 3, 2025
24 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/fix-cmake-omp-check branch December 3, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergeyKopienko SergeyKopienko SergeyKopienko approved these changes

@danhoeflinger danhoeflinger Awaiting requested review from danhoeflinger

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmitriy-sobolev @SergeyKopienko @timmiesmith